Add LoopTools

[matthewfeickert]

• Add LoopTools v2.16.
  • c.f. https://feynarts.de/looptools/
  • c.f Package mg5amcnlo dependencies hep-packaging-coordination/packaging-hep-simulation-stack#3
• Looptools currently only supports static linking, so following CFEP-18, create looptools-static output.
  • c.f. https://github.com/conda-forge/cfep/blob/main/cfep-18.md

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[github-actions]

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/looptools/meta.yaml) and found it was in an excellent condition.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/looptools/meta.yaml) and found some lint.

Here's what I've got...

For recipes/looptools/meta.yaml:

• ❌ The recipe must have a build/number section.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/looptools/meta.yaml) and found it was in an excellent condition.

[matthewfeickert]

For reviewers:

• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).

LoopTools vendors a significantly modified version of FF (c.f. hep-packaging-coordination/packaging-hep-simulation-stack#4 (comment)). FF is unlicensed Fortran code from 1998 and the original author has died. c.f. hep-packaging-coordination/packaging-hep-simulation-stack#4

• If static libraries are linked in, the license of the static library is packaged.

FF is statically linked into libooptools.a. As FF is unlicensed code (c.f. above) there is no additional license to include beyond LoopTools's GPL-3.0-only.

• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.

LoopTools only supports static linking at the moment given the author's decision to remove it. c.f. hep-packaging-coordination/packaging-hep-simulation-stack#4 (comment)

cc @t-hahn (LoopTools author) in the event they have any comments or corrections.

[matthewfeickert]

@conda-forge/staged-recipes, ready for review! This is a fortran recipe.

[github-actions]

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

[xhochy]

If it is static, it should need a run_exports.

[matthewfeickert]

@xhochy Hm, I thought from https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#export-runtime-requirements that I was setting run_exports here. Is there more clear documentation on how this works?

[matthewfeickert]

I was following krb5 which is given as the example package in CFEP-18:

https://github.com/conda-forge/krb5-feedstock/blob/ee87321c98e795ffa99a9fc1abf1570272153e90/recipe/meta.yaml#L13-L15

[matthewfeickert]

Hm, or should the run_exports be at the top level instead?

diff --git a/recipes/looptools/meta.yaml b/recipes/looptools/meta.yaml
index d9c5496de2..cd8b8240aa 100644
--- a/recipes/looptools/meta.yaml
+++ b/recipes/looptools/meta.yaml
@@ -11,14 +11,14 @@ source:
 
 build:
   number: 0
+  run_exports:
+    - {{ pin_subpackage('looptools-static', max_pin='x.x') }}
 
 outputs:
   - name: {{ name }}-static
 
     build:
       skip: true  # [win]
-      run_exports:
-        - {{ pin_subpackage('looptools-static', max_pin='x.x') }}
       ignore_run_exports_from:
         - {{ compiler('cxx') }}
       script:

[matthewfeickert]

@xhochy Sorry, looking at the krb5 run_exports again I see that they are just for krb5 not krb5-static.

If it is static, it should need a run_exports.

Was this a typo, and you were indicating that they should not have run_exports?

[matthewfeickert]

I'm going to assume "yes" given that the conda-build docs mention:

Some build or host Requirements section will impose a runtime requirement. Most commonly this is true for shared libraries (e.g. libpng), which are required for linking at build time, and for resolving the link at run time.

[matthewfeickert]

Thanks @xhochy. I'll push changes, but I also have some questions.

[matthewfeickert]

@xhochy Hm, I thought from https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#export-runtime-requirements that I was setting run_exports here. Is there more clear documentation on how this works?

[matthewfeickert]

@xhochy general question. As this is Fortran I've not been selecting a language team and just been mentining in my review request comment (#28292 (comment)) that the recipe is fortran . Do you have suggestions on how I can better communicate and label these sorts of PRs for the reviewers?