Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent internet loss causes downloads to hang indefinitely #53

Open
gmertes opened this issue Sep 28, 2021 · 1 comment
Open

Intermittent internet loss causes downloads to hang indefinitely #53

gmertes opened this issue Sep 28, 2021 · 1 comment

Comments

@gmertes
Copy link

gmertes commented Sep 28, 2021

I have unstable internet, and every so often my internet will disconnect for a second or two. When this happens right in the middle of a package download, the download will stall and hang indefinitely. The progress bar gets stuck and it will not recover by itself when connectivity is restored (ctrl+c also does nothing). The only solution is killing the process and restarting.

Is there a way to detect loss of connectivity during a transfer, or can we set a maximum time that a transfer is allowed to take before it kills itself and tries again? The current retry mechanic does not do anything for these kind of mid-download disconnects.

@gmertes
Copy link
Author

gmertes commented Sep 29, 2021

Potentially found the cause of the problem and submitted fix PR. Currently testing if this is the definite cause, but a socket timeout is consistent with the issue.

EDIT: I've confirmed that adding the timeout fixes my issue. I'm now seeing requests.exceptions.ReadTimeout exceptions causing the download to retry instead of hanging indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant