Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with conda-build=3 #97

Open
2 tasks
pelson opened this issue Feb 6, 2018 · 1 comment
Open
2 tasks

Compatibility with conda-build=3 #97

pelson opened this issue Feb 6, 2018 · 1 comment

Comments

@pelson
Copy link
Contributor

pelson commented Feb 6, 2018

#93 added conda-build 3 API compatibility, but did not add support for actually building recipes that use the features of conda-build 3.

This is a meta-issue for items that crop up:

  • AssertionError: modifying metadata after finalization (sorry, don't have the traceback to hand, but it comes from resolved_distribution getattr (line 45).
  • Computed binary filename from conda-build-all is different to what conda-build reports. This is because of the hash that gets generated is missing in conda-build-all.

Fixing these things is a pretty deep exercise, and if this is going to get fixed, conda-build-all will cease support for conda-build <3.

@kalefranz
Copy link
Contributor

kalefranz commented Mar 3, 2018

I ran into a single conda-build 3 related test failure in #96.

https://travis-ci.org/conda-tools/conda-build-all/jobs/341129488

======================================================================
FAIL: test_py_xx_version (conda_build_all.tests.unit.test_resolved_distribution.Test_BakedDistribution_resolve_all)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/conda/lib/python3.5/site-packages/conda_build_all-1.1.4.dev6+head.detached.at.fetch.head-py3.5.egg/conda_build_all/tests/unit/test_resolved_distribution.py", line 69, in test_py_xx_version
    self.assertEqual(ids, ['np18py27_0', 'np18py35_0'])
AssertionError: Lists differ: ['npxxpy>=27_0', 'npxxpy>=27_0'] != ['np18py27_0', 'np18py35_0']
First differing element 0:
'npxxpy>=27_0'
'np18py27_0'
- ['npxxpy>=27_0', 'npxxpy>=27_0']
+ ['np18py27_0', 'np18py35_0']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants