Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBM i build error #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix IBM i build error #37

wants to merge 3 commits into from

Conversation

ThePrez
Copy link

@ThePrez ThePrez commented May 13, 2020

Resolves #35 for IBM i

@chenghlee
Copy link

What operating system is this for (Linux, AIX, i5/OS)?

@ThePrez
Copy link
Author

ThePrez commented May 13, 2020

The operating system is IBM i, but more specifically it uses a runtime (named "PASE") that contains an AIX-derived runtime.
I was able to access an AIX machine and verified that this change should be in effect for AIX, too (_AIX).

@ThePrez
Copy link
Author

ThePrez commented May 13, 2020

Changed the check to _AIX, which will cover both IBM i and AIX.

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 15, 2022
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@ThePrez
Copy link
Author

ThePrez commented Mar 15, 2022

Would still appreciate consideration from maintainers. The change is well-contained and enables this package on two business computing platforms

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Mar 16, 2022
@jezdez
Copy link
Member

jezdez commented Oct 14, 2022

Hi @ThePrez, is https://developer.ibm.com/articles/au-gnu/ the best reference for _AIX to be the right value to check against?

@ThePrez
Copy link
Author

ThePrez commented Oct 17, 2022

Hi @ThePrez, is https://developer.ibm.com/articles/au-gnu/ the best reference for _AIX to be the right value to check against?

I certainly can't find anything better or more official-looking :/

@kenodegard kenodegard added type::feature request for a new feature or capability source::community catch-all for issues filed by community members in-progress issue is actively being worked on labels Sep 5, 2023
picosat.c Outdated Show resolved Hide resolved
Co-authored-by: Ken Odegard <[email protected]>
@conda-bot
Copy link
Contributor

conda-bot commented Sep 6, 2023

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ThePrez.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#834), and ping the bot to refresh the PR.

@kenodegard
Copy link
Contributor

@ThePrez our apologies for letting this fall through

if you can sign the CLA we'll get this merged ASAP

@beeankha
Copy link
Member

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 10, 2023
@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot removed the cla-signed [bot] added once the contributor has signed the CLA label Oct 10, 2023
@kenodegard
Copy link
Contributor

the CLA signature PR was prematurely merged, apologies for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress issue is actively being worked on source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::feature request for a new feature or capability
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

picosat.c build error
6 participants