From f3382617da9526f3b7cd3f6e9e288d352fda75b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 26 Dec 2023 14:48:28 -0300 Subject: [PATCH 1/2] gha: ccruntime_e2e: Avoid fail-fast MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every now and then we'll face errors that may be different depending on the distro being used, due to some distro changes or even some flakiness in the tests. Till everything is 100% stable, which is not the case yet, we better allow the tests to finish even if one test fails, giving us a better idea of the problem being a generic one or specific to flakiness / one distro. Signed-off-by: Fabiano Fidêncio --- .github/workflows/ccruntime_e2e.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ccruntime_e2e.yaml b/.github/workflows/ccruntime_e2e.yaml index afdb2685..27e267d8 100644 --- a/.github/workflows/ccruntime_e2e.yaml +++ b/.github/workflows/ccruntime_e2e.yaml @@ -11,6 +11,7 @@ jobs: e2e: name: operator tests strategy: + fail-fast: false matrix: runtimeclass: ["kata-qemu", "kata-clh"] instance: ["az-ubuntu-2004", "az-ubuntu-2204"] From 5c5364402f65220a6c0d3d1954833ea044cef3fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 26 Dec 2023 14:50:39 -0300 Subject: [PATCH 2/2] gha: ccruntime_e2e: Add a 45 minutes timeout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today I've faced one test hanging for more than one hour, stuck, without giving us any useful information, leaving the "cancel" option (which is up to the user to do) as the only option to finish the test and re-start it. As a possible way to avoid wasting resources for too long, let's simply add a timeout of 45 minutes in the execution of the e2e tests. This is 10 minutes more than what's been observed as the total time taken by this step. Signed-off-by: Fabiano Fidêncio --- .github/workflows/ccruntime_e2e.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ccruntime_e2e.yaml b/.github/workflows/ccruntime_e2e.yaml index 27e267d8..89851e67 100644 --- a/.github/workflows/ccruntime_e2e.yaml +++ b/.github/workflows/ccruntime_e2e.yaml @@ -25,6 +25,7 @@ jobs: sudo apt-get install -y ansible python-is-python3 - name: Run e2e tests + timeout-minutes: 45 run: | cd tests/e2e export PATH="$PATH:/usr/local/bin"