From f49cb47e975dda5605ff1f24be07d097c3d3d737 Mon Sep 17 00:00:00 2001 From: Gregory Date: Fri, 13 Sep 2024 00:39:31 +0500 Subject: [PATCH] Remove note about deadlock with partitioner Custom partitioner was removed a long time ago having predefined set of partitioners from librdkafka (https://github.com/confluentinc/confluent-kafka-python/pull/396) but 'known bug' note still exists. That note is misleading regarding the use of the 'partitioner' configuration property --- src/confluent_kafka/src/confluent_kafka.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/confluent_kafka/src/confluent_kafka.c b/src/confluent_kafka/src/confluent_kafka.c index 506c9a995..6e8e4aba3 100644 --- a/src/confluent_kafka/src/confluent_kafka.c +++ b/src/confluent_kafka/src/confluent_kafka.c @@ -22,13 +22,6 @@ /** * @brief KNOWN ISSUES * - * - Partitioners will cause a dead-lock with librdkafka, because: - * GIL + topic lock in topic_new is different lock order than - * topic lock in msg_partitioner + GIL. - * This needs to be sorted out in librdkafka, preferably making the - * partitioner run without any locks taken. - * Until this is fixed the partitioner is ignored and librdkafka's - * default will be used. * - KafkaError type .tp_doc allocation is lost on exit. * */