Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct zookeeper host for creating SCRAM users when hostname_aliasing_enabled=true #1559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

givanov
Copy link

@givanov givanov commented Feb 26, 2024

Description

When using hostname aliasing (hostname_aliasing_enabled=true) the create scram users tasks do not use the hostname aliases but instead the public hostname specified in the inventory. As such in cases where the machine we're running those tasks on can only talk to an internal interface and cannot to via the external one, the tasks fail. This PR addresses this by using the same hostname resolution for zookeeper in those tasks as the rest of the playbook

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

…tname_aliasing_enabled=true

Signed-off-by: Georgi Ivanov <[email protected]>
@givanov givanov requested a review from a team as a code owner February 26, 2024 10:57
Copy link

cla-assistant bot commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@givanov givanov changed the base branch from 7.6.0-post to master December 10, 2024 14:11
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Dec 10, 2024

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ givanov
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant