Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct zookeeper host for creating SCRAM users when hostname_aliasing_enabled=true #1559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: use the correct zookeeper host for creating SCRAM users when hostname_aliasing_enabled=true #1559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5d642c
fix: use the correct zookeeper host for creating SCRAM users when hos…
givanov Feb 22, 2024
6b4b275
Merge branch 'master' into fix/use_correct_zookeeper_host_with_aliasing
givanov Dec 10, 2024
9268a3a
fix: apply zk aliasing fix when creating chroot
givanov Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions roles/kafka_broker/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@
# Only runs with zookeeper
- name: Create Zookeeper chroot
shell: >
{{ binary_base_path }}/bin/zookeeper-shell {{ groups['zookeeper'][0] }}:{{zookeeper_client_port}} \
{{ binary_base_path }}/bin/zookeeper-shell {{ hostvars[groups['zookeeper'][0]] | confluent.platform.resolve_hostname }}:{{zookeeper_client_port}} \
{% if zookeeper_ssl_enabled|bool %}-zk-tls-config-file {{ kafka_broker.zookeeper_tls_client_config_file if kafka_broker_secrets_protection_enabled else kafka_broker.config_file }}{% endif %} \
create {{zookeeper_chroot}} ""
register: create_chroot
Expand All @@ -429,7 +429,7 @@
shell: |
{% if kafka_broker_final_properties['zookeeper.set.acl']|default('false')|lower == 'true' %}KAFKA_OPTS='-Djava.security.auth.login.config={{kafka_broker.jaas_file}}'{% endif %} \
{{ binary_base_path }}/bin/kafka-configs {% if zookeeper_ssl_enabled|bool %}--zk-tls-config-file {{ kafka_broker.zookeeper_tls_client_config_file if kafka_broker_secrets_protection_enabled else kafka_broker.config_file }}{% endif %} \
--zookeeper {{ groups['zookeeper'][0] }}:{{zookeeper_client_port}}{{zookeeper_chroot}} --alter \
--zookeeper {{ hostvars[groups['zookeeper'][0]] | confluent.platform.resolve_hostname }}:{{zookeeper_client_port}}{{zookeeper_chroot}} --alter \
--add-config 'SCRAM-SHA-512=[password={{ item.value['password'] }}]' \
--entity-type users --entity-name {{ item.value['principal'] }}
loop: "{{ sasl_scram_users_final|dict2items }}"
Expand All @@ -444,7 +444,7 @@
shell: |
{% if kafka_broker_final_properties['zookeeper.set.acl']|default('false')|lower == 'true' %}KAFKA_OPTS='-Djava.security.auth.login.config={{kafka_broker.jaas_file}}'{% endif %} \
{{ binary_base_path }}/bin/kafka-configs {% if zookeeper_ssl_enabled|bool %}--zk-tls-config-file {{ kafka_broker.zookeeper_tls_client_config_file if kafka_broker_secrets_protection_enabled else kafka_broker.config_file }}{% endif %} \
--zookeeper {{ groups['zookeeper'][0] }}:{{zookeeper_client_port}}{{zookeeper_chroot}} --alter \
--zookeeper {{ hostvars[groups['zookeeper'][0]] | confluent.platform.resolve_hostname }}:{{zookeeper_client_port}}{{zookeeper_chroot}} --alter \
--add-config 'SCRAM-SHA-256=[password={{ item.value['password'] }}]' \
--entity-type users --entity-name {{ item.value['principal'] }}
loop: "{{ sasl_scram256_users_final|dict2items }}"
Expand Down