Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose scrub.invalid.names config to scrub invalid schema names #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mukkachaitanya
Copy link
Member

Problem

confluentinc/schema-registry#1873 introduced the option to scrub invalid schema names, but the storage connectors can't take advantage of it as it's not an exposed config.

Solution

Expose the option to be configured. A lucrative alternative here would be instead to have a passthrough, say formatter.avro.* which let through all of AvroDataConfig options instead of exposing them one by one.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@mukkachaitanya mukkachaitanya requested a review from a team as a code owner November 25, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant