You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've set GOBIN=$GOPATH/bin. If I run go install github.com/coniks-sys/coniks-go/coniksserver/cli, I end up with the cli binary, which will conflict with the other CLIs. If I run go install github.com/coniks-sys/coniks-go/coniksserver/cli/coniksserver.go, I get a "No such file or directory" error unless I run the command from $GOPATH/src, which isn't ideal.
We should either rename the coniks*/cli packages to reflect their binary names, or refactor the coniks* packages so we can use the cli sub-packages as top-level packages.
The text was updated successfully, but these errors were encountered:
Right, like you said, that's an inelegant solution :) My preference would actually be to refactor all the code in the coniks* packages. I'm doing a little bit of that in #193 with the utils/binutils package; we can either expand on that or create a separate package. What do you think?
It makes sense, but I think we could do further refactoring:
Move cli packages to /cli/{auditor,server,bot,client}, we still can go install github.com/coniks-sys/coniks-go/cli/{auditor, server, bot, client} with expected name.
Move coniks* packages (e.g., /coniksserver/{server.go, listener.go} to impl/{auditor, server, bot, client} so we can reuse that code to build the C library or whatever. (I borrowed the name impl from KT).
This sounds good to me. I think it makes sense to solve this issue before I finish #193, I can give this a shot since I've already started refactoring a bit.
I've set
GOBIN=$GOPATH/bin
. If I rungo install github.com/coniks-sys/coniks-go/coniksserver/cli
, I end up with thecli
binary, which will conflict with the other CLIs. If I rungo install github.com/coniks-sys/coniks-go/coniksserver/cli/coniksserver.go
, I get a "No such file or directory" error unless I run the command from$GOPATH/src
, which isn't ideal.We should either rename the
coniks*/cli
packages to reflect their binary names, or refactor theconiks*
packages so we can use thecli
sub-packages as top-level packages.The text was updated successfully, but these errors were encountered: