Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go install of CLIs results in cli binary, not respective binary name #194

Closed
masomel opened this issue Nov 9, 2017 · 4 comments
Closed

Comments

@masomel
Copy link
Member

masomel commented Nov 9, 2017

I've set GOBIN=$GOPATH/bin. If I run go install github.com/coniks-sys/coniks-go/coniksserver/cli, I end up with the cli binary, which will conflict with the other CLIs. If I run go install github.com/coniks-sys/coniks-go/coniksserver/cli/coniksserver.go, I get a "No such file or directory" error unless I run the command from $GOPATH/src, which isn't ideal.

We should either rename the coniks*/cli packages to reflect their binary names, or refactor the coniks* packages so we can use the cli sub-packages as top-level packages.

@vqhuy
Copy link
Member

vqhuy commented Nov 9, 2017

Another inelegant solution is to go with git clone ... && make.

@masomel
Copy link
Member Author

masomel commented Nov 10, 2017

Right, like you said, that's an inelegant solution :) My preference would actually be to refactor all the code in the coniks* packages. I'm doing a little bit of that in #193 with the utils/binutils package; we can either expand on that or create a separate package. What do you think?

@vqhuy
Copy link
Member

vqhuy commented Nov 10, 2017

It makes sense, but I think we could do further refactoring:

  • Move cli packages to /cli/{auditor,server,bot,client}, we still can go install github.com/coniks-sys/coniks-go/cli/{auditor, server, bot, client} with expected name.
  • Move coniks* packages (e.g., /coniksserver/{server.go, listener.go} to impl/{auditor, server, bot, client} so we can reuse that code to build the C library or whatever. (I borrowed the name impl from KT).

@masomel
Copy link
Member Author

masomel commented Nov 10, 2017

This sounds good to me. I think it makes sense to solve this issue before I finish #193, I can give this a shot since I've already started refactoring a bit.

@masomel masomel self-assigned this Nov 13, 2017
@masomel masomel added this to the 0.2.0 milestone Nov 13, 2017
@masomel masomel mentioned this issue Nov 13, 2017
8 tasks
@masomel masomel modified the milestones: 0.2.0, 0.1.2 Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants