Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the usage of the registration bot optional/configurable #91

Closed
liamsi opened this issue Sep 23, 2016 · 1 comment
Closed

Make the usage of the registration bot optional/configurable #91

liamsi opened this issue Sep 23, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@liamsi
Copy link
Member

liamsi commented Sep 23, 2016

Currently the server can not take registration requests from outside (only through the bot). We might want to make this behavior optional/configurable such that the server can be run without the registration bot in between:

publicTypes := make(map[int]bool)
publicTypes[protocol.KeyLookupType] = true
publicTypes[protocol.KeyLookupInEpochType] = true
publicTypes[protocol.MonitoringType] = true
server.waitStop.Add(1)
go func() {
server.listenForRequests(publicLn, server.makeHandler(publicTypes))
server.waitStop.Done()
}()
// acceptable types for local connection
localTypes := make(map[int]bool)
localTypes[protocol.RegistrationType] = true

(Discussion started here: #86 (comment))

@masomel
Copy link
Member

masomel commented Sep 23, 2016

I should add that a case in which a server might not want/need to use the bot is when the server is also the identity provider (i.e. if Twitter ran its own key server for its users). The bot is primarily for key servers that are not first-party key servers, i.e. don't hand out identities in their own namespace, such as Tor Messenger.

@arlolra arlolra added this to the 0.1.0 milestone Nov 18, 2016
@vqhuy vqhuy closed this as completed in 5c92812 Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants