Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server "deadlock" #94

Closed
liamsi opened this issue Sep 24, 2016 · 2 comments · Fixed by #95
Closed

Server "deadlock" #94

liamsi opened this issue Sep 24, 2016 · 2 comments · Fixed by #95
Labels

Comments

@liamsi
Copy link
Member

liamsi commented Sep 24, 2016

By sending multiple lookup requests to the server it will block forever. Most probably this is because on lookup the RLocks are never released:

server.RLock()
default:
server.Lock()
}
response, e := server.dir.HandleOps(req)
switch req.Type {
case KeyLookupType, KeyLookupInEpochType, MonitoringType:
server.RLock()

(last line should be server.RUnlock() instead)

@liamsi liamsi added the bug label Sep 24, 2016
vqhuy added a commit that referenced this issue Sep 24, 2016
@vqhuy vqhuy mentioned this issue Sep 24, 2016
@vqhuy
Copy link
Member

vqhuy commented Sep 24, 2016

Thanks! I submitted #95 to fix this bug.

@liamsi
Copy link
Member Author

liamsi commented Sep 24, 2016

Thanks! I submitted #95 to fix this bug.

Wow, that was quick :-) I also already changed it on my branch (I was wondering why my client made the server stop...) but thanks I'll merge that asap.

@vqhuy vqhuy closed this as completed in #95 Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants