-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run-time styling options before calling render #26
Comments
@charandas this is an interesting idea. Definitely makes me wish we got better errors for invalid styles than we do now. I'm open to your idea of using a |
meowcoder
added a commit
to meowcoder/mbgl-renderer
that referenced
this issue
Jun 9, 2020
- see consbio#26 for preRenderFn. - pngOptions are passed to the sharp.png() method as is.
meowcoder
added a commit
to meowcoder/mbgl-renderer
that referenced
this issue
Jul 5, 2020
- see consbio#26 for preRenderFn. - pngOptions are passed to the sharp.png() method as is.
meowcoder
added a commit
to meowcoder/mbgl-renderer
that referenced
this issue
Jul 5, 2020
- see consbio#26 for preRenderFn. - pngOptions are passed to the sharp.png() method as is.
meowcoder
added a commit
to meowcoder/mbgl-renderer
that referenced
this issue
Jul 7, 2020
- see consbio#26 for preRenderFn. - pngOptions are passed to the sharp.png() method as is.
meowcoder
added a commit
to meowcoder/mbgl-renderer
that referenced
this issue
Jul 7, 2020
- see consbio#26 for preRenderFn. - pngOptions are passed to the sharp.png() method as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would love to be able to do
map.setPaintProperty
before this library callsmap.render
to give me thepng
output.The motivation would be that runtime styling in GL JS actually returns proper errors like:
Whereas if my
style.json
has an incorrect color like that, it just fails silently to apply the expression to say,fill-color
.Also, run-time styling would be nice for the calling-user as they won't be interfacing with
style.json
but instead have access to allmap
APIs supported by gl-native. Also, for context, runtime styling options for node seem to be mature and have been in support since at least 2017.The text was updated successfully, but these errors were encountered: