Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and refactor #21

Open
kgarwoodsdzwa opened this issue Feb 23, 2023 · 2 comments
Open

Lint and refactor #21

kgarwoodsdzwa opened this issue Feb 23, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kgarwoodsdzwa
Copy link
Collaborator

In preparation for Earthranger integration, code must be linted and readme's updated.

@kgarwoodsdzwa kgarwoodsdzwa added the enhancement New feature or request label Feb 23, 2023
@kgarwoodsdzwa kgarwoodsdzwa self-assigned this Feb 23, 2023
@iingram
Copy link
Member

iingram commented Feb 23, 2023

Here are some of the things we want to achieve in this issue:

  1. code passes flake8
  2. code passes pylint
  3. updating of README to reflect how things currently work
  4. some possible renaming of modules (and maybe other identifiers) to reflect changes that have occurred in how the project is organized
  5. some refactoring on how we use our AniML package in CougarVision
  6. further updating of the README based on what we do in steps 4 and 5

The above are in pretty good order for how we should tackle them. More specifically, I think we should start with the web_scraping.py module and work towards it passing flake8 and pylint and then start looking at other parts of the project.

@iingram
Copy link
Member

iingram commented Mar 8, 2023

We hadn't discussed this yet and are basically doing it but to state it outright, this issue is focused on "CougarGram" which is to say the camera trap part of CougarVision i.e. not the streaming IP camera part. So, that is fetch_and_alert.py and all the bits it depends on. This also brings up the question of whether fetch_and_alert.py should itself be renamed to cougargram.py or some other name that we come up with instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants