Skip to content

Commit

Permalink
package_managers: yarn: Set 'enableMirror' to False on RC override
Browse files Browse the repository at this point in the history
Now that we set 'enableGlobalCache' and 'globalFolder', we don't need
to set mirroring on dep fetching.

Signed-off-by: Erik Skultety <[email protected]>
  • Loading branch information
eskultety committed Nov 30, 2023
1 parent fbbfa19 commit b776bd4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cachi2/core/package_managers/yarn/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def _set_yarnrc_configuration(project: Project, output_dir: RootedPath) -> None:
yarn_rc.enable_telemetry = False
yarn_rc.ignore_path = True
yarn_rc.unsafe_http_whitelist = []
yarn_rc.enable_mirror = True
yarn_rc.enable_mirror = False
yarn_rc.enable_scripts = False
yarn_rc.enable_global_cache = True
yarn_rc.global_folder = str(output_dir.join_within_root("deps", "yarn"))
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/package_managers/yarn/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def test_set_yarnrc_configuration(mock_write: mock.Mock) -> None:
"checksumBehavior": "throw",
"enableGlobalCache": True,
"enableImmutableInstalls": True,
"enableMirror": True,
"enableMirror": False,
"enableScripts": False,
"enableStrictSsl": True,
"enableTelemetry": False,
Expand Down

0 comments on commit b776bd4

Please sign in to comment.