-
Notifications
You must be signed in to change notification settings - Fork 614
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Separate lint + enable on other platforms
Signed-off-by: apostasie <[email protected]>
- Loading branch information
Showing
3 changed files
with
85 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
name: lint | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
- 'release/**' | ||
pull_request: | ||
|
||
env: | ||
GO_VERSION: 1.23.x | ||
|
||
jobs: | ||
go: | ||
timeout-minutes: 5 | ||
name: "go | ${{ matrix.goos }} | ${{ matrix.gonext }}" | ||
runs-on: "${{ matrix.os }}" | ||
defaults: | ||
run: | ||
shell: bash | ||
strategy: | ||
matrix: | ||
include: | ||
- os: ubuntu-24.04 | ||
goos: linux | ||
- os: ubuntu-24.04 | ||
goos: freebsd | ||
# FIXME: this is currently failing in a non-sensical way, so, running on linux instead... | ||
# - os: windows-2022 | ||
- os: ubuntu-24.04 | ||
goos: windows | ||
- os: ubuntu-24.04 | ||
goos: linux | ||
# This allows the canary script to select any upcoming golang alpha/beta/RC | ||
gonext: canary | ||
- os: ubuntu-24.04 | ||
goos: freebsd | ||
gonext: canary | ||
- os: ubuntu-24.04 | ||
goos: windows | ||
gonext: canary | ||
env: | ||
GOOS: "${{ matrix.goos }}" | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 1 | ||
- name: Set GO env | ||
run: | | ||
# If gonext is specified, get the latest available golang pre-release instead of the major version | ||
if [ "$gonext" != "" ]; then | ||
. ./hack/build-integration-canary.sh | ||
canary::golang::latest | ||
fi | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
check-latest: true | ||
cache: true | ||
- name: golangci-lint | ||
uses: golangci/golangci-lint-action@v6 | ||
with: | ||
args: --verbose | ||
|
||
other: | ||
timeout-minutes: 5 | ||
name: yaml | shell | imports order | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 1 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
check-latest: true | ||
cache: true | ||
- name: yaml | ||
run: make lint-yaml | ||
- name: shell | ||
run: make lint-shell | ||
- name: go imports ordering | ||
run: | | ||
go install -v github.com/incu6us/goimports-reviser/v3@latest | ||
make lint-imports |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,27 +15,6 @@ env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
jobs: | ||
lint: | ||
runs-on: "ubuntu-24.04" | ||
timeout-minutes: 20 | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 1 | ||
- name: Set GO env | ||
run: | | ||
. ./hack/build-integration-canary.sh | ||
canary::golang::latest | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
check-latest: true | ||
cache: true | ||
- name: golangci-lint | ||
uses: golangci/[email protected] | ||
with: | ||
args: --verbose | ||
|
||
linux: | ||
runs-on: "ubuntu-24.04" | ||
timeout-minutes: 40 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,32 +13,6 @@ env: | |
GO_VERSION: 1.23.x | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-24.04 | ||
timeout-minutes: 20 | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 1 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
check-latest: true | ||
cache: true | ||
- name: golangci-lint | ||
uses: golangci/[email protected] | ||
with: | ||
version: v1.60.1 | ||
args: --verbose | ||
- name: yamllint-lint | ||
run: make lint-yaml | ||
- name: shellcheck | ||
run: make lint-shell | ||
- name: go imports ordering | ||
run: | | ||
go install -v github.com/incu6us/goimports-reviser/v3@latest | ||
make lint-imports | ||
test-unit: | ||
timeout-minutes: 5 | ||
name: unit | ${{ matrix.goos }} | ||
|