-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate lint + enable on other platforms #3575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
.github/workflows/lint.yml
Outdated
- os: ubuntu-24.04 | ||
goos: linux | ||
# This allows the canary script to select any upcoming golang alpha/beta/RC | ||
canary: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably true
should be quoted as `"true", otherwise it is likely parsed as a boolean literal?
Signed-off-by: apostasie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
GitHub Copilot gave me this garbled answer 😅
|
Really cute :D. Like “whatever mumble fail facepalm try this other unrelated thing oh look over there!” |
That’s the thing with copilot. |
Sometimes I just want to give up on CI. I truly believe that the move we saw a decade ago towards "hey what about all CI is yaml+shell+shit" was a true disaster. I think dagger.io has a point (and probably a few others), but they are not quite there yet. Having to debug a mix of random code failures, test failures, third party service failures, CI system failures is always a massive PITA, and no contributor (understandably) wants to look into any of that and just prefers to brush it under the carpet and hit "retry". The industry needs a better solution, with a modern view on it that let developers focus on what really matters: code issues. /hate-love-CI |
Yep, I wish GHA (and other CIs) had a feature to automatically restart the CI when it failed due to a "not-your-fault" reason (network connectivity issue, host crash, EC2 spot instance preemption, etc.) |
Breakout of #3535
This breaks lint tasks into their own file (others are overcrowded), and enables linting for freebsd and windows.