Enforce go imports grouping in CI

[djdongjin]

By default goimports organize imports into 2 groups

import (
  std pkgs

  third-party / non-std pkgs
)

The local-prefixes option (https://golangci-lint.run/usage/linters/#goimports) in golang-ci (correspond to -local flag in goimports CLI https://cs.opensource.google/go/x/tools/+/refs/tags/v0.27.0:cmd/goimports/goimports.go;l=54) will enforce 3 groups instead:

import (
  std pkgs

  third-party pkgs

  local pkgs
)

I think this will provide a clear/consistent view of dependency import groups.

[apostasie]

Import grouping is already being enforced:

• https://github.com/containerd/nerdctl/blob/main/.github/workflows/lint.yml#L75-L78
• https://github.com/containerd/nerdctl/blob/main/Makefile#L77
• https://github.com/containerd/nerdctl/blob/main/hack/lint-imports.sh

The current configuration enforces:

import (
  std pkgs

  third-party pkgs

  non-local-containerd pkgs

  local pkgs
)

For example:
https://github.com/containerd/nerdctl/blob/main/pkg/cmd/login/login.go#L19-L37

[djdongjin]

Import grouping is already being enforced:

great. didn't aware we already have it.