Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable gocritic linter #988

Merged
merged 1 commit into from
Oct 18, 2023
Merged

enable gocritic linter #988

merged 1 commit into from
Oct 18, 2023

Conversation

mmorel-35
Copy link
Contributor

Signed-off-by: Matthieu MOREL [email protected]

@coveralls
Copy link

coveralls commented Jun 11, 2023 •
edited
Loading

Coverage Status

coverage: 71.573% (-0.03%) from 71.605% when pulling 4683716 on mmorel-35:linter-gocritic into 2cfe797 on containernetworking:main.

@mmorel-35
enable gocritic linter
4683716 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Contributor Author

Hi @squeed ,
What do you think about this ?

@squeed
Copy link
Member

squeed commented Oct 18, 2023

Sure, seems fine.

@squeed squeed merged commit 82b44c5 into containernetworking:main Oct 18, 2023
5 checks passed
@mmorel-35 mmorel-35 deleted the linter-gocritic branch October 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @coveralls @squeed