-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only reset compression if its not valid #2255
base: main
Are you sure you want to change the base?
Conversation
@mtrmac Hi Miroslav, long time :) I think the failure in the podman test PR is an infra failure, but if I'm wrong lmk and I'll try and work out what happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the one podman test failure can be ignored as it is a flake and totally unrelated to this code.
I leave it to @mtrmac to comment on the code here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Logic LGTM; it would be best to see containers/podman#24673 be reviewed and mostly-pass before merging this.
8ceb2ec
to
ff282b1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jamstah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If we reset the default compression method, force compression no longer works. Signed-off-by: James Hewitt <[email protected]>
ff282b1
to
b6b2a9a
Compare
Review comments addressed and push to both PRs for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note to self: Merge after the test PR passes.
Thanks!
If we reset the default compression method, force compression no longer works.
Fixes containers/podman#23942
Podman test containers/podman#24673