Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reset compression if its not valid #2255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jamstah
Copy link

@Jamstah Jamstah commented Nov 26, 2024

If we reset the default compression method, force compression no longer works.

Fixes containers/podman#23942
Podman test containers/podman#24673

@Jamstah
Copy link
Author

Jamstah commented Nov 26, 2024

@mtrmac Hi Miroslav, long time :)

I think the failure in the podman test PR is an infra failure, but if I'm wrong lmk and I'll try and work out what happened.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the one podman test failure can be ignored as it is a flake and totally unrelated to this code.
I leave it to @mtrmac to comment on the code here

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Logic LGTM; it would be best to see containers/podman#24673 be reviewed and mostly-pass before merging this.

libimage/push.go Show resolved Hide resolved
libimage/push.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jamstah
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

libimage/push.go Show resolved Hide resolved
libimage/push.go Outdated Show resolved Hide resolved
If we reset the default compression method, force compression no longer works.

Signed-off-by: James Hewitt <[email protected]>
@Jamstah
Copy link
Author

Jamstah commented Nov 29, 2024

Review comments addressed and push to both PRs for testing.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note to self: Merge after the test PR passes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use --force-compression with --format v2s2
3 participants