From 98e7c384060808525eb37189159a1657e250bd78 Mon Sep 17 00:00:00 2001
From: Reinhard Tartler <siretart@tauware.de>
Date: Wed, 6 Nov 2024 06:12:08 -0500
Subject: [PATCH] Avoid crash with empty resolv.conf

Fixes: #417
Signed-off-by: Reinhard Tartler <siretart@gmail.com>
---
 pkg/services/dns/dns_config_unix.go |  7 +++++++
 pkg/services/dns/dns_test.go        | 11 +++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/pkg/services/dns/dns_config_unix.go b/pkg/services/dns/dns_config_unix.go
index de8a48ed..ef66be39 100644
--- a/pkg/services/dns/dns_config_unix.go
+++ b/pkg/services/dns/dns_config_unix.go
@@ -3,6 +3,7 @@
 package dns
 
 import (
+	"errors"
 	"net"
 	"net/netip"
 
@@ -10,6 +11,8 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+var errEmptyResolvConf = errors.New("no DNS servers configured in /etc/resolv.conf")
+
 func getDNSHostAndPort() ([]string, error) {
 	conf, err := dns.ClientConfigFromFile("/etc/resolv.conf")
 	if err != nil {
@@ -27,5 +30,9 @@ func getDNSHostAndPort() ([]string, error) {
 			hosts = append(hosts, net.JoinHostPort(server, conf.Port))
 		}
 	}
+
+	if len(hosts) == 0 {
+		return []string{}, errEmptyResolvConf
+	}
 	return hosts, nil
 }
diff --git a/pkg/services/dns/dns_test.go b/pkg/services/dns/dns_test.go
index 95ff875e..66c25d82 100644
--- a/pkg/services/dns/dns_test.go
+++ b/pkg/services/dns/dns_test.go
@@ -2,6 +2,7 @@ package dns
 
 import (
 	"context"
+	"errors"
 	"net"
 	"testing"
 	"time"
@@ -23,7 +24,11 @@ var _ = ginkgo.Describe("dns add test", func() {
 	var server *Server
 
 	ginkgo.BeforeEach(func() {
-		server, _ = New(nil, nil, []types.Zone{})
+		var err error
+		server, err = New(nil, nil, []types.Zone{})
+		if errors.Is(err, errEmptyResolvConf) {
+			ginkgo.Skip("Skipping test, no DNS Servers found")
+		}
 	})
 
 	ginkgo.It("should add dns zone with ip", func() {
@@ -230,7 +235,9 @@ type ARecord struct {
 func TestDNS(t *testing.T) {
 	log.Infof("starting test DNS servers")
 	nameserver, cleanup, err := startDNSServer()
-	require.NoError(t, err)
+	if err != nil {
+		t.Skip("Failed to setup start DNS server, skipping test")
+	}
 	defer cleanup()
 	time.Sleep(100 * time.Millisecond)
 	log.Infof("test DNS servers started")