Skip to content

Commit

Permalink
test: fix broken dns TXT lookup test
Browse files Browse the repository at this point in the history
It sems the TXT entry for wikipedia.org changed which is causing the
test to fail. Fix it by only checking for a partial match.

In general it seems like a bad idea to rely on public domains not on our
control for any of these tests but this is a bigger problem and I only
want to get the test to pass for now.

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Jul 23, 2024
1 parent 7782952 commit d62ac1b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ var _ = ginkgo.Describe("dns", func() {
ginkgo.It("should resolve TXT for wikipedia.org", func() {
out, err := sshExec("nslookup -query=txt wikipedia.org")
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
gomega.Expect(string(out)).To(gomega.ContainSubstring(`"v=spf1 -all"`))
gomega.Expect(string(out)).To(gomega.ContainSubstring(`"v=spf1`))
})

ginkgo.It("should resolve gateway.containers.internal", func() {
Expand Down

0 comments on commit d62ac1b

Please sign in to comment.