Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make test on non-x86_64 arches #357

Closed
cfergeau opened this issue May 15, 2024 · 3 comments
Closed

Fix make test on non-x86_64 arches #357

cfergeau opened this issue May 15, 2024 · 3 comments

Comments

@cfergeau
Copy link
Collaborator

The tests in test can only be built on x86_64 as test/fcos.go uses a getFCOSDownload method which is only defined in test/fcos_amd64.go
This means go test ./test will only be buildable on an x86_64 machine.
This is problematic as make test in .github/workflows/go.yml is run on a macos node which can be arm64 or amd64, and thus the action will fail depending on which node is picked.

@cfergeau
Copy link
Collaborator Author

macos-latest github runners are switching to M1 which do not support nested virt, which is going to be another issue for our tests. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
The ubuntu runners may support nested virt now though actions/runner-images#7541

@cfergeau
Copy link
Collaborator Author

I created #358 for this.

@cfergeau
Copy link
Collaborator Author

cfergeau commented Nov 6, 2024

This was fixed by #362

@cfergeau cfergeau closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant