Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for a open_basedir configuration #599

Open
aschempp opened this issue Oct 10, 2020 · 5 comments
Open

Check for a open_basedir configuration #599

aschempp opened this issue Oct 10, 2020 · 5 comments
Labels
Milestone

Comments

@aschempp
Copy link
Member

@aschempp may be the Contao Manager could check for an open_basedir configuration such as this? There are a few hosters out there that set the open_basedir to the document root by default. And I think Plesk does that by default too.

Originally posted by @fritzmg in #594 (comment)

@aschempp
Copy link
Member Author

What should be validaten on?

@fritzmg
Copy link
Contributor

fritzmg commented Oct 12, 2020

May be after the Contao Manager determined the installation directory, check it against the current open_basedir configuration and show an error with an explanation.

Plus a link to the performance section in the manual, explaining why this setting should not be used at all.

@aschempp aschempp added this to the 1.3 milestone Oct 20, 2020
@aschempp aschempp modified the milestones: 1.3, 1.4 Jan 6, 2021
@aschempp
Copy link
Member Author

aschempp commented Jan 7, 2021

@fritzmg sorry I can't figure out what was meant here, do you still remember? What would the explanation be about?
Be aware that there are no "warnings" in the system check, we can't "recommend" a performance setting (yet).

@fritzmg
Copy link
Contributor

fritzmg commented Jan 7, 2021

It needs to be an error anyway, not a warning. The original issue was about an open_basedir setting, where the path was pointing to the web/ sub folder of the Contao Installation. Some hosters use a variable for the open_basedir setting that represents the DocumentRoot of the vhost - which obviously will not work for applications that use a sub folder as its document root. The idea was to evaluate open_basedir, if set, and check for such a specific misconfiguration.

@aschempp
Copy link
Member Author

aschempp commented Jan 8, 2021

What would not work? If open_basedir points to foo/bar, I can always create foo/bar/web. And if the folder is /foo/bar/web, then Contao Manager will ask to create /foo/bar/web/example.com/web for you, because it can't write to /foo/bar (due to open_basedir).

@aschempp aschempp modified the milestones: 1.4, 1.x Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants