Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - show version badges to installed packages #823

Open
berecont opened this issue Aug 28, 2024 · 13 comments
Open

Feature Request - show version badges to installed packages #823

berecont opened this issue Aug 28, 2024 · 13 comments

Comments

@berecont
Copy link

Feature Request

Is it possible to display the new version badges in the installed packages as well?
This would have the advantage of giving a first impression of whether the Contao version can be upgraded.

@aschempp
Copy link
Member

you can see that information in the details popup already. I think showing this in the list of installed packages could be misleading, because the version you currently use does not match the shown compatibility.

@zoglo
Copy link
Member

zoglo commented Aug 28, 2024

Wouldn't be "too misleading" (take it with a grain of salt), it's more about "where" to show it.

Been thinking about adding it when I did the PR in the package-list, however it's more about way too many information that are visible at once (mind that there is also the responsive view) 🤔

Edit

Or rather - if I am still on 4.13 and I see that all my installed plugins are "contao 5" ready... maybe that would lead me to update to C5?

It would still need to set the proper version in that case...

@fritzmg
Copy link
Contributor

fritzmg commented Aug 28, 2024

because the version you currently use does not match the shown compatibility.

When would that be the case?

@zoglo
Copy link
Member

zoglo commented Aug 28, 2024

When would that be the case?

E.g. using in terminal42/contao-leads in version 1.x for C4.13 but 3.x being the one for Contao 5.
The version that you have in your composer.json wouldn't be compatible with C5.

@berecont
Copy link
Author

I think there is a misunderstanding. I meant that the possible compatibility of the versions is shown here - regardless of the version you have installed.

In other words, just as it is in the general overview. The installed version is not queried here, but the latest package and the highest compatibility of the Contao version is displayed.

@fritzmg
Copy link
Contributor

fritzmg commented Aug 28, 2024

E.g. using in terminal42/contao-leads in version 1.x for C4.13 but 3.x being the one for Contao 5.
The version that you have in your composer.json wouldn't be compatible with C5.

But the extension in general is compatible with Contao 5 - that's the point. That's what this feature request is about. If you want to update from Contao 4.13 to Contao 5 you'd want to know at a glance whether all of your extensions are compatible with Contao 5. If you have 20 extensions installed you'd not want to klick into the detail view 20 times just to check if one of them does not have the badge for Contao 5.

@zoglo
Copy link
Member

zoglo commented Aug 28, 2024

If someone has a good design proposal, I wouldn't mind implementing it and making a PR.

It just feels very stuffed right now with all the information

@berecont
Copy link
Author

cm-feature-request-823
just put <ul> before the <h1>
same as in the general view

@zoglo
Copy link
Member

zoglo commented Aug 29, 2024

I agree with the other versions but this is very stuffed and completely out of place
image

@fritzmg
Copy link
Contributor

fritzmg commented Aug 29, 2024

Looks fine to me. If anything, the download, license and like information could be removed. Surely the Contao Version compatibility is more useful in the installed packages screen than those.

@zoglo
Copy link
Member

zoglo commented Aug 29, 2024

We could also position it there.

@aschempp wdyt about this:

Looks fine to me. If anything, the download, license and like information could be removed. Surely the Contao Version compatibility is more useful in the installed packages screen than those.

@fritzmg
Copy link
Contributor

fritzmg commented Aug 29, 2024

imho it does not need to re removed. I assume it's there so it is consistent with the package search. The same should apply to the version badges. But if something has to be removed, it should not be the version badges, as that is arguably more valuable information than the amount of downloads, likes or the license information.

@aschempp
Copy link
Member

I would probably place it beside the stats. I don't really like it though, but I don't know why. I agree the stats are not important either, maybe we should revise the package list in general. But not as a quick fix 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants