Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing service of type "IReCaptchaValidatorFactory" #8

Closed
wants to merge 1 commit into from
Closed

Conversation

adaamz
Copy link
Contributor

@adaamz adaamz commented Feb 23, 2017

fixes #7

Please consider updating 1.5.x with php <5.6 syntax ->setImplement('Minetro\Forms\reCAPTCHA\IReCaptchaValidatorFactory')

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.9%) to 92.105% when pulling 48a08f1 on CZechBoY:patch-1 into 46bd050 on minetro:master.

@@ -36,6 +36,7 @@ public function loadConfiguration()
$builder = $this->getContainerBuilder();

$builder->addDefinition($this->prefix('validator'))
->setImplement(Minetro\Forms\reCAPTCHA\IReCaptchaValidatorFactory::class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you please don't use FQN? :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of 1.5.x I will update it by my own with FQN.

fixes #7

Please consider updating 1.5.x with php <5.6 syntax `->setImplement('Minetro\Forms\reCAPTCHA\IReCaptchaValidatorFactory')`
@f3l1x
Copy link
Member

f3l1x commented Feb 23, 2017

Closed via e416c82. Thank you.

@f3l1x f3l1x closed this Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Service of type IReCaptchaValidatorFactory not registered in DIC
3 participants