Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the recommended way to handle deprecations? #557

Open
bshaffer opened this issue Dec 20, 2023 · 2 comments
Open

what is the recommended way to handle deprecations? #557

bshaffer opened this issue Dec 20, 2023 · 2 comments

Comments

@bshaffer
Copy link

I assume since it's neither a feat or a fix, the recommended way to handle deprecations would be chore(deprecation): or simply chore: deprecate such and such. But would a deprecated: tag or deprecation: tag also make sense? Curious if anyone has any thoughts on this.

@javier-godoy
Copy link

My colleagues use deprecate: We don't like using feat: because we reserve it for introducing new features, and we don't like chore: either, because it doesn't convey a Semantic Versioning level. However, many guidelines based on conventional commits don't specify a type for deprecations.

@ph-One
Copy link

ph-One commented Jan 18, 2024

Thoughts on feat(deprecate): Deprecate {{ thing }}? This would generate a feature release (as I would expect from a deprecation). One other option would be to use chore!: Deprecate {{ thing }}, but this equates to a MAJOR version change, which doesn't exactly feel right in all cases, especially since deprecation isn't truly a breaking change, just the first step in a breaking change. 🤷‍♂️

I'm here for the suggestions, as this feels like a common action that isn't called out in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants