Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPM package issues (version specification, and url) #71

Open
iislucas opened this issue Aug 30, 2018 · 1 comment
Open

MPM package issues (version specification, and url) #71

iislucas opened this issue Aug 30, 2018 · 1 comment

Comments

@iislucas
Copy link
Contributor

iislucas commented Aug 30, 2018 •
edited
Loading

The package.json file specified exact angular versions, but angular uses semantic versioning. This means that attempting to update angular breaks on projects that include the authorship npm package as a dependency.

Suggested fixes:

  • Use semantic versioning (e.g. "^6.0.0" instead of "6.0.0") for package dependencies.
  • Specify the github URL in the package.json file so that the source listing in NPM is correct.

If you can fix and cut a new release, that would be awesome and unblock some downstream projects I have using it.
@iislucas
Copy link
Contributor Author

iislucas commented Aug 30, 2018 •
edited
Loading

I think this PR fixes the NPM deps:
#72

but... I noticed that half the tests are failing on master too. So probably need to fix that first?

@rachelrosengoogle rachelrosengoogle removed their assignment Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iislucas @rachelrosengoogle