-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cxl-lumo-styles): limit secondary font style in ul to .entry-content #368
Conversation
size-limit report 📦
|
Yeah, in theory it will improve current state. But we just discussed things with @heshfekry and may be opting for a deep simplification by "reset all to single typeface, expand from there". Let's see what the decision will be there, this PR might then need to morph into just removing usage (but not definition) of secondary typeface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkraav what about global p
style? It was also set to secondary font family and one of the pieces affected is course about section:
Task linked: CU-86aytq9gd Fix paragraph vs element fonts |
Yep, highly likely also needs to be contained with
|
It is already. First line could be dropped @freudFlintstone.
Yeah, it's tricky.
Will be next step. For now let's just focus on patching recent changes. |
@pawelkmpt how are you getting that? I only see the new one: If that's from your IDE? If that's a merge, there's a problem with it |
I linked to the piece of code in
I played with it myself and it seems more complex than ul, ol. |
fa1363f
to
0c023ac
Compare
As requested in cxl-wpstarter PR
Tested locally: