Merge pull request #4688 from coralproject/feat/env-mongodb-max-pool-…

…size allow `maxPoolSize` to be configurable by env var (defaults to 50)
coralproject · Oct 31, 2024 · cd56de7 · cd56de7
2 parents 8094b3e + 53dae81
commit cd56de7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/server/src/core/server/config.ts b/server/src/core/server/config.ts
@@ -186,6 +186,12 @@ const config = convict({
     env: "MONGODB_ARCHIVE_URI",
     sensitive: true,
   },
+  mongodb_max_pool_size: {
+    doc: "Max pool size for the MongoDB driver.",
+    format: Number,
+    default: 50,
+    env: "MONGODB_MAX_POOL_SIZE",
+  },
   redis: {
     doc: "The Redis database to connect to.",
     format: "redis-uri",

diff --git a/server/src/core/server/data/context.ts b/server/src/core/server/data/context.ts
@@ -140,9 +140,11 @@ export function isArchivingEnabled(config: Config): boolean {
 export async function createMongoContext(
   config: Config
 ): Promise<MongoContext> {
+  const maxPoolSize = config.get("mongodb_max_pool_size");
+
   // Setup MongoDB.
   const liveURI = config.get("mongodb");
-  const live = (await createMongoDB(liveURI)).db;
+  const live = (await createMongoDB(liveURI, maxPoolSize)).db;
 
   // If we have an archive URI, use it, otherwise, default
   // to using the live database
@@ -154,7 +156,7 @@ export async function createMongoContext(
   ) {
     archive = live;
   } else {
-    archive = (await createMongoDB(archiveURI)).db;
+    archive = (await createMongoDB(archiveURI, maxPoolSize)).db;
   }
 
   return new MongoContextImpl(live, archive);

diff --git a/server/src/core/server/services/mongodb/index.ts b/server/src/core/server/services/mongodb/index.ts
@@ -3,14 +3,18 @@ import { Db, MongoClient } from "mongodb";
 import { WrappedInternalError } from "coral-server/errors";
 import logger from "coral-server/logger";
 
-async function createMongoClient(mongoURI: string): Promise<MongoClient> {
+async function createMongoClient(
+  mongoURI: string,
+  maxPoolSize = 50
+): Promise<MongoClient> {
   try {
     return await MongoClient.connect(mongoURI, {
       // believe we don't need this since the new driver only uses
       // the new URL parser. But am leaving this here in case we have
       // issues with URL's and want to investigate into it.
       // useNewUrlParser: true,
       ignoreUndefined: true,
+      maxPoolSize,
     });
   } catch (err) {
     throw new WrappedInternalError(
@@ -45,10 +49,11 @@ interface CreateMongoDbResult {
  * @param config application configuration.
  */
 export async function createMongoDB(
-  mongoURI: string
+  mongoURI: string,
+  maxPoolSize?: number
 ): Promise<CreateMongoDbResult> {
   // Connect and create a client for MongoDB.
-  const client = await createMongoClient(mongoURI);
+  const client = await createMongoClient(mongoURI, maxPoolSize);
 
   logger.info("mongodb has connected");