Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): set correct build output dir #143

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(ci): set correct build output dir #143

merged 1 commit into from
Nov 25, 2024

Conversation

fionera
Copy link
Contributor

@fionera fionera commented Nov 25, 2024

No description provided.

@fionera fionera requested a review from fzipi November 25, 2024 19:42
fzipi
fzipi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to followup with a test that the generated .deb package works as intended? Or is too cumbersome?

@fionera
Copy link
Contributor Author

fionera commented Nov 25, 2024

Dunno. I think we can do that but we may want to generalize these tests across the other repos. Afaik this is the only one with a .deb? I didn't saw anything on a first glance. Feel free to make an issue but I don't think its really necessary

@fionera fionera merged commit 5dba63d into main Nov 25, 2024
5 checks passed
@fionera fionera deleted the fix-build branch November 25, 2024 20:15
This was referenced Nov 26, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fionera @fzipi