feat: uses memoization to decrease memory consumption. #13
Conversation
| } | ||
|
|
||
| // makeDoer returns a function that executes and returns the results of the given function | ||
| func makeDoer(cache *sync.Map) func(string, func() (interface{}, error)) (interface{}, error, bool) { |
There was a problem hiding this comment.
Sorry I know I suggested copying the same PR. But realized that since this is wasilibs we shouldn't use any of these sync mechanisms - there are no threads (maybe in the future but I'd rather deal with it when it happens). So it'd be good to simplify the implementation and tests to just use a normal map and no other libraries.
There was a problem hiding this comment.
I had the same thought about the sync package but then realise people could
still want to use wasilibs with go, and hence the sync isn't? Still we can
remove it for now until someone requests for it.
There was a problem hiding this comment.
Yeah that's probably fine. I have bad memories of a sync pool not actually pooling for some time in TinyGo and have some caution towards that package but if sync.Map is mostly a normal map in practice it should be ok
No description provided.