You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the mergeActions function, the code logic skips over the rule’s block action and always appends the default disruptive action when merging actions. Specifically, the following code:
Even when action.Key == "block", the system still adds the default disruptive action in certain cases. This is a bit confusing to me, as typically, if a rule explicitly specifies block, it should execute that action, not require the default action to be added as well.
My questions are:
Why does mergeActions add the default disruptive action even when action.Key == "block"?
What is the intended purpose behind this behavior? Is it to ensure some rules always execute a disruptive action, or to prevent potential misconfigurations?
Could this logic lead to unnecessary duplication of actions or affect the expected behavior of rules?
I would appreciate an explanation of the reasoning behind this design decision.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Issue Description:
In the
mergeActions
function, the code logic skips over the rule’sblock
action and always appends the default disruptive action when merging actions. Specifically, the following code:Even when
action.Key == "block"
, the system still adds the default disruptive action in certain cases. This is a bit confusing to me, as typically, if a rule explicitly specifiesblock
, it should execute that action, not require the default action to be added as well.My questions are:
mergeActions
add the default disruptive action even whenaction.Key == "block"
?I would appreciate an explanation of the reasoning behind this design decision.
Beta Was this translation helpful? Give feedback.
All reactions