Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

Negotiation CorDapp Missing a Time-window #106

Open
adelrustum opened this issue Apr 23, 2020 · 1 comment
Open

Negotiation CorDapp Missing a Time-window #106

adelrustum opened this issue Apr 23, 2020 · 1 comment

Comments

@adelrustum
Copy link

  • In the Negotiation CorDapp both ProposalState and TradeState belong to the same contract ProposalAndTradeContract.
  • Inside the contract, it mandates for Propose command that there should be a time-window (see here).
  • But proposalFlow (which uses Propose command for the transaction) doesn't add a time-window; so the transaction verification would definitely fail (see here).
  • Btw, the above mentioned flow doesn't call tx.verify() before signing the transaction (see here).
@adelrustum
Copy link
Author

Update: AcceptanceFlow and ModificationFlow don't add a time-window either; even though it's required by the contract.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant