Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move versionary script here #2859

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Feb 16, 2024

When we emptied this script out of
https://github.com/coreos/fedora-coreos-releng-automation/ in [1], I'm not sure why I decided to move it to cosa instead of this repo, where it clearly belongs much better.

When we emptied this script out of
https://github.com/coreos/fedora-coreos-releng-automation/ in [[1]],
I'm not sure why I decided to move it to cosa instead of this repo,
where it clearly belongs much better.

[1]: coreos/coreos-assembler#3113
@dustymabe
Copy link
Member

When we emptied this script out of https://github.com/coreos/fedora-coreos-releng-automation/ in [1], I'm not sure why I decided to move it to cosa instead of this repo, where it clearly belongs much better.

I kind of understand why we moved it to COSA. This repo doesn't really have much code in it other than what is under the ci/ dir and used for CI.

@dustymabe
Copy link
Member

This repo doesn't really have much code in it other than what is under the ci/ dir and used for CI.

and I'm not sure if that's the most ideal path forward, but clearly it makes whatever you are trying to do here easier so I'm fine with it.

@jlebon
Copy link
Member Author

jlebon commented Feb 20, 2024

Yeah. The way I think of it is that the versioning scheme is a core part of the OS definition, and so belongs better here. Another approach that would capture this more would be to fold this into the rpm-ostree manifest itself, e.g. via some automatic-version-script: path/to/script knob, but that doesn't seem worth the complexity. Not opposed to moving it to ci/ (or maybe better a scripts/ dir?).

@jlebon jlebon merged commit bc8a569 into coreos:testing-devel Feb 20, 2024
3 checks passed
@jlebon jlebon deleted the pr/versionary branch February 20, 2024 17:06
jlebon added a commit to jlebon/coreos-assembler that referenced this pull request Mar 4, 2024
This was moved to coreos/fedora-coreos-config:
coreos/fedora-coreos-config#2859

And the pipeline now knows to use that instead:
coreos/fedora-coreos-pipeline#961
jmarrero pushed a commit to coreos/coreos-assembler that referenced this pull request Mar 6, 2024
This was moved to coreos/fedora-coreos-config:
coreos/fedora-coreos-config#2859

And the pipeline now knows to use that instead:
coreos/fedora-coreos-pipeline#961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants