workflows/openshift-os allow custom branches #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Feb 27, 2024
There was a problem hiding this comment.
My 2c is to rework this to use a choice input instead. 3 inputs is a lot to get right (esp. the branch-name one; forgetting to update that one would stomp on an open PR opened against a completely different branch -- though maybe the create-pull-request action would error out on that).
jbtrystram
force-pushed
the
bump_job_custom_branches_fixup
branch
from
60db0a4 to
dc6ef4b
Compare
|
Ok, here is a working version of the workflow :) Successful run (on my fork to avoid noise on openshift/os ) : https://github.com/jbtrystram/fedora-coreos-config/actions/runs/8081693445/job/22080845871 |
jbtrystram
force-pushed
the
bump_job_custom_branches_fixup
branch
from
dc6ef4b to
dff6a67
Compare
the base branch should be checked out initally otherwise the rebase will fails. Also fixup the log generation to remove the hard-coded testing-devel Make the sources branches to a pickup menu and generate the destination branch and the base PR branch from that to avoid errors.
jbtrystram
force-pushed
the
bump_job_custom_branches_fixup
branch
from
8565000 to
951311c
Compare
jlebon
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the source branch to open a PR from
as well as the target branch to compare against.
This is useful for backporting work
Also update the action as there were some deprecation warnings