feat: use test host name for marker if localhost alias #370
Conversation
Signed-off-by: Felipe Zipitria <[email protected]>
| if err != nil { | ||
| return nil, fmt.Errorf("ftw/run: can't resolve destination %+v: %w", dest, err) | ||
| } |
There was a problem hiding this comment.
Don't know if this even make sense. Maybe just ignoring the error and moving on?
There was a problem hiding this comment.
I think it does. Running the test makes no sense because resolution will fail again.
|
What's the use case? |
|
Ok, I understand the use case. |
| if err != nil { | ||
| return nil, fmt.Errorf("ftw/run: can't resolve destination %+v: %w", dest, err) | ||
| } |
There was a problem hiding this comment.
I think it does. Running the test makes no sense because resolution will fail again.
| } | ||
| // we only take the first IP address | ||
| if net.ParseIP(addrs[0]).IsLoopback() { | ||
| host = dest.DestAddr |
There was a problem hiding this comment.
Apart from the comment, I think this should be set to the host entry of the current stage. The Host header will be the deciding factor for choosing the location / virtual host, so if we change the host here to mylocalhostalias but the test request has a host name of anotheralias, the two requests will end up in different locations / virtual hosts.
| host = dest.DestAddr | |
| // With multiple locations / virtual hosts, logs can be written to different files, | |
| // in which case the internal requests for marking and flushing must end up in the | |
| // same log file (host name match). | |
| host = dest.DestAddr |
what
why
caveats
Fixes #361