Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantitative: Rule 921170 always flags in error (PL 3 rule) #393

Closed
RedXanadu opened this issue Nov 6, 2024 · 1 comment · Fixed by #407
Closed

quantitative: Rule 921170 always flags in error (PL 3 rule) #393

RedXanadu opened this issue Nov 6, 2024 · 1 comment · Fixed by #407

Comments

@RedXanadu
Copy link
Member

Rule 921170 is not a detection rule: it is an admin/scaffold rule designed to make the HTTP parameter pollution rules.

SecRule ARGS_NAMES "@rx ." \
    "id:921170,\
    phase:2,\
    ⋮
    setvar:'TX.paramcounter_%{MATCHED_VAR_NAME}=+1'"
$ ./ftw quantitative --crs-path ~/.git/coreruleset --corpus-lang=eng --corpus-source=news --corpus-year=2020 --corpus-size=10K --paranoia-level=4
11:09AM INF ⏳Running quantitative tests with 10 goroutines
Run 10000 payloads in 9.657304833s
Total False positive ratio: 26481/10000 = 2.6481
False positives per rule id:
  920220: 130 false positives
  920221: 130 false positives
  920272: 3299 false positives
  920273: 10000 false positives
  921170: 10000 false positives
  ⋮
@RedXanadu
Copy link
Member Author

It looks like go-ftw also cannot correctly handle rule 920273 (from the results above).

@M4tteoP M4tteoP changed the title Rule 921170 always flags in error (PL 3 rule) quantitative: Rule 921170 always flags in error (PL 3 rule) Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant