Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isolated #300

Merged
merged 2 commits into from
May 19, 2024
Merged

Implement isolated #300

merged 2 commits into from
May 19, 2024

Conversation

theseion
Copy link
Collaborator

Refs #296

@theseion theseion marked this pull request as draft May 11, 2024 13:16
@theseion theseion force-pushed the implement-isolated branch 2 times, most recently from a7c8568 to ed1a137 Compare May 13, 2024 04:58
@theseion theseion marked this pull request as ready for review May 13, 2024 04:59
@theseion theseion requested a review from fzipi May 13, 2024 04:59
dune73
dune73 reviewed May 15, 2024
View reviewed changes
check/logs_test.go Outdated Show resolved Hide resolved
@dune73
Copy link
Member

dune73 commented May 15, 2024

Thank you

@theseion theseion requested a review from M4tteoP May 19, 2024 15:21
M4tteoP
M4tteoP approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@theseion theseion merged commit f19d3ca into coreruleset:main May 19, 2024
3 checks passed
@theseion theseion deleted the implement-isolated branch May 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dune73 dune73 dune73 left review comments

@M4tteoP M4tteoP M4tteoP approved these changes

@fzipi fzipi Awaiting requested review from fzipi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theseion @dune73 @M4tteoP