Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNavItem.as is now a required property #295

Closed
abompard opened this issue Oct 14, 2024 · 1 comment
Closed

CNavItem.as is now a required property #295

abompard opened this issue Oct 14, 2024 · 1 comment

Comments

@abompard
Copy link

Hey!

Since the last couple refactors on CNavItem, the as property as become mandatory in Typescript:

image

The first CNavItem on line 14 has a as, the second one on line 19 doesn't and trigger a type check error.
I think it's coming from the recent refactors on packages/coreui-vue/src/components/nav/CNavItem.ts

The actual console type check error is:

 src/components/AdminSubHeader.vue:19:6 - error TS2345: Argument of type '{}' is not assignable to parameter of type '(Partial<{} | { [x: string]: any; }> & Omit<{ readonly as: string; readonly disabled?: boolean | undefined; readonly active?: boolean | undefined; readonly href?: string | undefined; } & VNodeProps & AllowedComponentProps & ComponentCustomProps, never>) & Record<...>'.

19     <CNavItem>
        ~~~~~~~~
@abompard abompard changed the title CNavItem.as is not a required property CNavItem.as is now a required property Oct 14, 2024
abompard added a commit to fedora-infra/fmn that referenced this issue Oct 14, 2024
Ref: coreui/coreui-vue#295

Signed-off-by: Aurélien Bompard <[email protected]>
renovate bot pushed a commit to fedora-infra/fmn that referenced this issue Oct 14, 2024
Ref: coreui/coreui-vue#295

Signed-off-by: Aurélien Bompard <[email protected]>
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant