Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate files from being returned GetManifestFilenames #630

Open
doughertym opened this issue May 31, 2023 · 0 comments
Open

Avoid duplicate files from being returned GetManifestFilenames #630

doughertym opened this issue May 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@doughertym
Copy link
Contributor

The current implementation of the AbstractManifestFinder.GetManifestFilenames can return the same file multiple times. The primary cause of this seems to be related to multiple IManifestFinder instance of the same type being registered more than once. Therefore, the ManifestFinderRegistry should only register an AbstractManifestFinder if it has not already been registered.
@doughertym doughertym moved this to Backlog in Freshli May 31, 2023
@doughertym doughertym changed the title Prevent duplicate files from being returned GetManifestFilenames Avoid duplicate files from being returned GetManifestFilenames May 31, 2023
@doughertym doughertym moved this from Backlog to In Progress in Freshli May 31, 2023
@mscottford mscottford added the bug Something isn't working label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Freshli
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscottford @doughertym