fix(TVMT HP) - Fixes issue #4636 of OHIF related with infinite loop of setViewReference #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
reviewed
Feb 24, 2025
| @@ -151,7 +151,8 @@ abstract class BaseVolumeViewport extends Viewport { | |||
| this.initialViewUp = viewUp; | |||
|
|
|||
| if (resetCamera) { | |||
| this.resetCamera(); | |||
| const t = this as unknown as IVolumeViewport; | |||
| t.resetCamera({ resetOrientation: false, resetRotation: false }); | |||
There was a problem hiding this comment.
doesn't this.resetCamera({...}
work? why the t assignment?
There was a problem hiding this comment.
Because I had some typescript issues. The IDE was looking a wrong function signature in Viewport.cs and not VolumeViewport.cs. OHIF wouldn't compile because the viewport.cs resetCamera doesn't accept these attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The fix is related to OHIF issue [Bug] Infinite loop in TMTV mode #4636
A recursive call of setViewReference was causing OHIF to stall.
Changes & Results
The fix was finally located in CS3D and the way we had to resetCamera in BaseVolumeViewport->applyViewOrientation
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment