Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Storing RPCs in xarray #837

Open
remi-braun opened this issue Dec 11, 2024 · 3 comments
Open

ENH: Storing RPCs in xarray #837

remi-braun opened this issue Dec 11, 2024 · 3 comments
Labels
proposal Idea for a new feature.

Comments

@remi-braun
Copy link
Contributor

Hi there,

Currently, the RPCs are not stored into xarray (whereas the GCPs since #376).
Moreover, rasterio offers the possibility to retrieve them.

So even if I have opened the xarray, I need to add this annoying bit of code to retrieve them:

with rasterio.open("my/raster.tif") as ds:
    rpcs = ds.rpcs

Moreover, if I'm right, you are handling them in reprojection, so they should - in my opinion - be retrievable without calling rasterio.

Is there any specific reason to not storing them? Or maybe I've overlooked something?

@remi-braun remi-braun added the proposal Idea for a new feature. label Dec 11, 2024
@snowman2
Copy link
Member

Just hasn't been implemented. A MR is welcome.

@remi-braun
Copy link
Contributor Author

Thanks for the quick answer.
I don't really know what it implies in rioxarray, as I dont fully understand all the whereabouts of the current GCP loading.
Should it be done with the same pattern?

@snowman2
Copy link
Member

It likely should be done following a similar pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Idea for a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants