Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC draws params from params file, not from expDef #103

Open
kevin-j-miller opened this issue Feb 18, 2019 · 0 comments
Open

MC draws params from params file, not from expDef #103

kevin-j-miller opened this issue Feb 18, 2019 · 0 comments

Comments

@kevin-j-miller
Copy link
Contributor

Currently, MC draws its parameter list from the parameters file, not from the expDef. If you try to run an experiment with a params file that's missing a param, mc will send it to the rig computer, which will fail silently.

Suggested fix:
MC should instead draw the parameter list from the expDef file, then attempt to draw values from the parameters file. If it can't find a value for a parameter, it should throw a warning then use the default value. If a param is specified in the expDef but has no value (i.e. it's not in the param file, and there's no default) MC should refuse to run that experiment.

@k1o0 k1o0 self-assigned this Feb 19, 2019
@jkbhagatio jkbhagatio self-assigned this May 8, 2019
@jkbhagatio jkbhagatio added the bug label May 8, 2019
@jkbhagatio jkbhagatio mentioned this issue May 15, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants