Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules and dependencies #81

Open
k1o0 opened this issue Dec 7, 2018 · 2 comments
Open

Submodules and dependencies #81

k1o0 opened this issue Dec 7, 2018 · 2 comments

Comments

@k1o0
Copy link
Contributor

k1o0 commented Dec 7, 2018

Currently we have a load of submodules in Rigbox, however they are gradually becoming more and more dependent of Rigbox functions. We should be careful to ensure that these submodules can be used alone, otherwise we may as well fold them into Rigbox entirely...

@jkbhagatio
Copy link
Member

Along these lines, I've been thinking about ways to do package/file re-organization so Signals can be completely standalone (e.g. moving some files from Rigbox +exp to Signals ?)

@k1o0
Copy link
Contributor Author

k1o0 commented Dec 7, 2018

If you're thinking about SignalsExp then that won't solve the problem; there's absolutely no way of running SignalsExp without Rigbox. inferParameters could be moved though, but only to the cortexlab signals fork as @dendritic probably doesn't want to support that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants