Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include metric name in max series per metric limit exceeded error #6416

Open
eeldaly opened this issue Dec 11, 2024 · 1 comment · May be fixed by #6422
Open

Include metric name in max series per metric limit exceeded error #6416

eeldaly opened this issue Dec 11, 2024 · 1 comment · May be fixed by #6422

Comments

@eeldaly
Copy link

eeldaly commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
When receiving an errMaxSeriesPerMetricLimitExceeded error, the metric name is not displayed.

Describe the solution you'd like
Include the metric name in the error message.

Additional context
When a user hits the max-series per metric name limit, they should know which metric caused the limit to be reached so that they can reduce their active series for that limit or increase the limit.

@dosubot dosubot bot added the type/feature label Dec 11, 2024
@yeya24
Copy link
Contributor

yeya24 commented Dec 11, 2024

Thanks! Proposal makes sense to me.

func (l *Limiter) FormatError(userID string, err error) error {

We have both formatMaxSeriesPerMetricError and formatMaxMetadataPerMetricError. We should include metric name to both error messages

@eeldaly eeldaly linked a pull request Dec 12, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants