Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting los gives error #23

Open
zdplayground opened this issue Mar 9, 2023 · 2 comments
Open

setting los gives error #23

zdplayground opened this issue Mar 9, 2023 · 2 comments

Comments

@zdplayground
Copy link
Contributor

los = self._get_los(los)

Hi Arnaud,
When I tested to generate some lognormal mock with los='z', it gives some error, e.g.
'''
250 if los is not None:
--> 251 los = self._get_los(los)
252 self.attrs['los'] = los
253 self.set_complex_delta_field()

AttributeError: 'LagrangianLinearMock' object has no attribute '_get_los'.
'''
I guess that we need to change line 251 to "los = _get_los(los)". Could you check it?

Thanks,
Zheije

@adematti
Copy link
Member

adematti commented Mar 9, 2023

yes, you're right, thanks for the bug report! would you like to submit or PR? or push directly :)

@zdplayground
Copy link
Contributor Author

Sure, I'm happy to push it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants