Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate events errors in v0.52 icacontroller #7624

Closed
damiannolan opened this issue Dec 6, 2024 · 2 comments
Closed

Propagate events errors in v0.52 icacontroller #7624

damiannolan opened this issue Dec 6, 2024 · 2 comments
Milestone

Comments

@damiannolan
Copy link
Member

This error should be propagated and returned from this func.

The likelihood of these errors surfacing from EventManager are pretty much zero, but at some point in a future far away it may be possible for it to error - given a different impl of event service.

None the less, its good practise to actually return the errors and not panic and rely on grpc recovery interceptor

Originally posted by @damiannolan in #7587 (comment)

@Sruthi2357
Copy link

@damiannolan Can I work on this?

@damiannolan
Copy link
Member Author

Hey, this is already implemented in #7261 which we are working towards merging asap. I will close this issue

@github-project-automation github-project-automation bot moved this from Backlog to Done in IBC-GO Eureka Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants