Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display failure message when simulations return invalid timestamps #35

Open
steven-cd opened this issue Apr 7, 2021 · 2 comments
Open

Comments

@steven-cd
Copy link
Member

steven-cd commented Apr 7, 2021

The results for one of the simulations I gave during the last JBC demo cannot be viewed, instead giving an Internal Server Error (https://covid-modelling-stg.epcc.ed.ac.uk/simulations/11?model=mrc-ide-covid-sim). I don't know what about this simulation is different that could have caused that. Other models for the same simulation work okay, e.g. https://covid-modelling-stg.epcc.ed.ac.uk/simulations/11?model=basel

@steven-cd
Copy link
Member Author

Okay, I've got far enough down the chain to identify that the data produced by CovidSim for this simulation had 0s for everything, including the timestamps (i.e. the data had timestamps: [0, 0, 0, 0, ...] instead of the expected timestamps: [1, 2, 3, 4, ...]. This seems to be in the output from CovidSim itself (in results.avNE.severity.xls). I'm not sure there's much point debugging this much further - I suspect it would be more fruitful to work on upgrading CovidSim first before seeing if it can be recreated.

The UI was not designed to cope with this, and it results in unexpectedly undefined variables - I put in some changes locally to ignore these, which then gives a view like:
Screenshot_2021-04-07 COVID Modeling
That's not ideal, but is probably better than breaking the app altogether.

I feel like there's probably a better solution however - detecting the problem earlier on either in the web-ui or in the model-runner, in order to display a "Failed" message

@steven-cd
Copy link
Member Author

I've committed my work-around as b6d3607, but I think it is worth leaving the issue open in order to come up with a better approach and/or fix the underlying issue

@steven-cd steven-cd changed the title Internal server error on simulation results Display failure message when simulations return invalid timestamps Jun 11, 2021
@steven-cd steven-cd transferred this issue from another repository May 5, 2022
@steven-cd steven-cd transferred this issue from another repository May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant