Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with price impact banner #1515

Closed
1 task
elena-zh opened this issue Nov 28, 2022 · 1 comment · Fixed by #3418
Closed
1 task

Issues with price impact banner #1515

elena-zh opened this issue Nov 28, 2022 · 1 comment · Fixed by #3418
Assignees
@shoom3301
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression

Comments

@elena-zh
Copy link

elena-zh commented Nov 28, 2022 •
edited
Loading

-- [ ] 1. There should be NO checkbox on the warning in the Expert mode: no box.png

  • 2. Impossible to uncheck the Price impact on Swap form in regular mode
    should not be checked
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Nov 28, 2022
@elena-zh elena-zh added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional and removed Low Severity indicator for defects. It won't cause any major break-down of the system labels Dec 5, 2022
@elena-zh elena-zh changed the title [1.25] Price impact flashing on Order confirm modal Issues with price impact banner Jan 23, 2023
@elena-zh elena-zh added Low Severity indicator for defects. It won't cause any major break-down of the system and removed Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Apr 17, 2023
@shoom3301 shoom3301 mentioned this issue Dec 5, 2023
Merged
3 tasks
@shoom3301 shoom3301 self-assigned this Dec 5, 2023
@shoom3301
Copy link
Collaborator

Fixed in #3418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove uknown price impact warning flickering cowprotocol/cowswap
2 participants
@shoom3301 @elena-zh